plan: refine code about maxonerow #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Dec 26, 2017
plan/plan.go
Outdated
| case *LogicalMaxOneRow, *LogicalExists: | ||
| p.maxOneRow = true | ||
| } | ||
| if len(p.children) == 1 { | ||
| switch p.self.(type) { | ||
| case *LogicalExists, *LogicalAggregation, *LogicalProjection: | ||
| p.basePlan.schema.Keys = nil | ||
| case *LogicalLock: | ||
| p.basePlan.schema.Keys = p.basePlan.children[0].Schema().Keys |
shenli
reviewed
Dec 26, 2017
| { | ||
| // Test MaxOneRow for limit. | ||
| sql: "select (select * from (select b from t limit 1) x where x.b = t1.b) from t t1", | ||
| best: "Join{DataScan(t1)->DataScan(t)->Projection->Limit}(t1.b,x.b)->Projection->Projection", |
There was a problem hiding this comment.
How can we tell there is a MaxOneRow attribute in the plan?
There was a problem hiding this comment.
Before this test, the plan contains an Apply op.
|
/run-all-tests |
|
LGTM |
|
/run-common-test |
|
/run-all-tests |
|
@hanfei1991 Please fix CI. |
|
/run-common-test -tidb-test=pr/439 |
|
/run-integration-common-test -tidb-test=pr/439 |
winoros
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move maxOneRow out of schema to do further optimize