Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: truncate time part for current_date columns (#54045) #54946

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #54045

What problem does this PR solve?

Issue Number: close #53746

Problem Summary:

When TiDB uses current_date as default value, "hour:minuate:second" is not truncated correctly. As a result, the queries with equal condition cannot match.

What changed and how does it work?

Truncate time part for current_date.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 26, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 08:28:07.281568731 +0000 UTC m=+78084.500330335: ☑️ agreed by tangenta.
  • 2024-08-02 08:30:07.633257012 +0000 UTC m=+78204.852018619: ☑️ agreed by XuHuaiyu.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@42b624c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #54946   +/-   ##
================================================
  Coverage               ?   71.6885%           
================================================
  Files                  ?       1466           
  Lines                  ?     426604           
  Branches               ?          0           
================================================
  Hits                   ?     305826           
  Misses                 ?     100201           
  Partials               ?      20577           
Flag Coverage Δ
unit 71.6885% <72.7272%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 57.8032% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.9842% <0.0000%> (?)

@tangenta
Copy link
Contributor

tangenta commented Aug 5, 2024

/retest

3 similar comments
@tangenta
Copy link
Contributor

tangenta commented Aug 5, 2024

/retest

@tangenta
Copy link
Contributor

tangenta commented Aug 5, 2024

/retest

@tangenta
Copy link
Contributor

tangenta commented Aug 5, 2024

/retest

@Ivy-YinSu
Copy link

/test unit-test

Copy link

tiprow bot commented Aug 5, 2024

@Ivy-YinSu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 787fe24 into pingcap:release-8.1 Aug 5, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-54045-to-release-8.1 branch August 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants