-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: truncate time part for current_date columns (#54045) #54946
expression: truncate time part for current_date columns (#54045) #54946
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54946 +/- ##
================================================
Coverage ? 71.6885%
================================================
Files ? 1466
Lines ? 426604
Branches ? 0
================================================
Hits ? 305826
Misses ? 100201
Partials ? 20577
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
/test unit-test |
@Ivy-YinSu: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #54045
What problem does this PR solve?
Issue Number: close #53746
Problem Summary:
When TiDB uses
current_date
as default value, "hour:minuate:second" is not truncated correctly. As a result, the queries with equal condition cannot match.What changed and how does it work?
Truncate time part for
current_date
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.