*: refine pipelined dml benchmarks #54844
Conversation
Signed-off-by: ekexium <[email protected]>
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/M
|
Hi @ekexium. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54844 +/- ##
=================================================
- Coverage 74.7330% 56.2314% -18.5016%
=================================================
Files 1557 1679 +122
Lines 363550 616048 +252498
=================================================
+ Hits 271692 346413 +74721
- Misses 72140 246256 +174116
- Partials 19718 23379 +3661
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/session/bench_test.go
Outdated
| @@ -1949,6 +1950,8 @@ var batchNum = 100 | |||
| var batchSize = 100 | |||
|
|
|||
| func BenchmarkPipelinedSimpleInsert(b *testing.B) { | |||
| failpoint.Enable("tikvclient/pipelinedSkipResolveLock", "return") | |||
There was a problem hiding this comment.
Does it mean the it's tested without commit the prewrite locks?
There was a problem hiding this comment.
Yes. Hopefully it will make the test more stable.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
pkg/session/bench_test.go
Outdated
| @@ -2072,6 +2081,8 @@ func BenchmarkPipelinedDelete(b *testing.B) { | |||
| } | |||
|
|
|||
| func BenchmarkPipelinedReplaceNoDuplicates(b *testing.B) { | |||
| failpoint.Enable("tikvclient/pipelinedSkipResolveLock", "return") | |||
| defer failpoint.Disable("tikvclient/pipelinedSkipResolveLock") | |||
There was a problem hiding this comment.
You should check the return result to see if a failpoint exists.
|
@ekexium: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: ekexium <[email protected]>
ti-chi-bot
bot
added
size/L
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
bench-refine-p-dml
branch
from
162eb46 to
11e8a24
Compare
* upstream/master: (93 commits) disjoinset: add generic impl (pingcap#54917) planner: derive index filters for mv index paths (pingcap#54877) br: cli refactor backup error handling logic (pingcap#54697) expression: fix infinity loop in `timestampadd` (pingcap#54916) planner: import more expand test. (pingcap#54962) planner: use code-gen to generate CloneForPlanCache method for some operators (pingcap#54957) test: fix flaky test TestFailSchemaSyncer (pingcap#54958) planner: move logical show into logicalop pkg. (pingcap#54928) privilege: Remove TestAbnormalMySQLTable (pingcap#54925) resource_control: support unlimited keyword when setting the resource group (pingcap#54704) ddl: fix a data race on localRowCntListener Written() (pingcap#54484) lightning: fix SET SESSION on connection pool (pingcap#54927) planner: move logical mem-table to logicalop pkg. (pingcap#54903) table: Add `CachedTableSupport` and `TemporaryTableSupport` for `MutateContext` (pingcap#54900) executor: fix index_hash_join hang when context canceled (pingcap#54855) statistics: add metrics for unneeded analyze table (pingcap#54822) *: refine pipelined dml benchmarks (pingcap#54844) ddl: assign table IDs for jobs submitted to queue (pingcap#54880) *: avoid using Tables field of model.DBInfo, use API instead (pingcap#52302) planner: remove useless check (pingcap#54907) ...
What problem does this PR solve?
Issue Number: ref #50215
Problem Summary:
What changed and how does it work?
Refine some benchmarks to make them more realistic and stable.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.