parser, variable: fix #5478, make 'set transaction read only' works. #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coocood @shenli @tiancaiamao PTAL |
shenli
reviewed
Dec 25, 2017
| // issue #5478 | ||
| _, err = tk.Exec("set session transaction read write;") | ||
| _, err = tk.Exec("set global transaction read write;") | ||
| r = tk.MustQuery(`select @@session.tx_read_only, @@global.tx_read_only, @@session.transaction_read_only, @@global.transaction_read_only;`) |
There was a problem hiding this comment.
Is there any difference between transaction_read_only and tx_read_only?
There was a problem hiding this comment.
transaction_read_only was added in MySQL 5.7.20 as an alias for tx_read_only, which is now deprecated and is removed in MySQL 8.0. Applications should be adjusted to use transaction_read_only in preference to tx_read_only.
|
LGTM |
|
LGTM |
|
/run-all-tests |
|
/run-integration-common-test -tidb-test=pr/435 |
|
/run-common-test -tidb-test=pr/435 |
|
/run-integration-common-test |
|
/run-common-test |
|
/run-integration-common-test -tidb-test=pr/436 |
|
/run-integration-common-test |
coocood
approved these changes
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this pr, use jdbc, in some case, we will get below error :