Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refactor the BaseExecutor and remove session context in IndexLookUpExecutor and IndexReaderExecutor. #54626

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 15, 2024

What problem does this PR solve?

Issue Number: close #54625

Similar to #51397. This PR uses the BaseExecutorV2 and removed the session context in the IndexLookUpExecutor and IndexReaderExecutor.

As these two executors have a very close connection. I refactored them in a single PR.

What changed and how does it work?

  1. Remove the BaseExecutor internal and replace it with BaseExecutorV2.
  2. Add a new indexLookUpExecutorContext and indexReaderExecutorContext, which include all information needed by the selection executor.
  3. Remove the needed session context inside the redact log helper.
  4. Remove the session context arguments for a function in table pkg.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

    No logic change. It should be protected by existing tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2024
@YangKeao YangKeao force-pushed the support-indexlookup branch from 8557fb3 to d7bb1ff Compare July 15, 2024 07:58
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 32 lines in your changes missing coverage. Please review.

Project coverage is 55.7279%. Comparing base (f00bf9a) to head (f60c4b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54626         +/-   ##
=================================================
- Coverage   72.8004%   55.7279%   -17.0726%     
=================================================
  Files          1555       1671        +116     
  Lines        437655     606461     +168806     
=================================================
+ Hits         318615     337968      +19353     
- Misses        99426     245275     +145849     
- Partials      19614      23218       +3604     
Flag Coverage Δ
integration 21.6343% <78.3783%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5462% <ø> (+6.6782%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2024
@YangKeao YangKeao requested a review from xhebox July 19, 2024 06:37
@YangKeao YangKeao force-pushed the support-indexlookup branch from d7bb1ff to fc3fa3f Compare July 19, 2024 06:39
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
Copy link

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 03:28:26.855294258 +0000 UTC m=+410928.846235730: ☑️ agreed by lcwangchao.
  • 2024-07-19 07:08:20.394354005 +0000 UTC m=+596922.385295473: ☑️ agreed by xhebox.

@YangKeao YangKeao force-pushed the support-indexlookup branch from fc3fa3f to 6b3c4bb Compare July 19, 2024 07:44
Copy link

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 19, 2024
@YangKeao YangKeao force-pushed the support-indexlookup branch from 6b3c4bb to f60c4b8 Compare July 22, 2024 04:31
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 07f7774 into pingcap:master Jul 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the BaseExecutor in IndexLookUpExecutor and IndexReaderExecutor.
3 participants