-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: refactor the BaseExecutor
and remove session context in IndexLookUpExecutor
and IndexReaderExecutor
.
#54626
Conversation
8557fb3
to
d7bb1ff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54626 +/- ##
=================================================
- Coverage 72.8004% 55.7279% -17.0726%
=================================================
Files 1555 1671 +116
Lines 437655 606461 +168806
=================================================
+ Hits 318615 337968 +19353
- Misses 99426 245275 +145849
- Partials 19614 23218 +3604
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d7bb1ff
to
fc3fa3f
Compare
[LGTM Timeline notifier]Timeline:
|
fc3fa3f
to
6b3c4bb
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yang Keao <[email protected]>
…cutor Signed-off-by: Yang Keao <[email protected]>
6b3c4bb
to
f60c4b8
Compare
What problem does this PR solve?
Issue Number: close #54625
Similar to #51397. This PR uses the
BaseExecutorV2
and removed the session context in theIndexLookUpExecutor
andIndexReaderExecutor
.As these two executors have a very close connection. I refactored them in a single PR.
What changed and how does it work?
BaseExecutor
internal and replace it withBaseExecutorV2
.indexLookUpExecutorContext
andindexReaderExecutorContext
, which include all information needed by the selection executor.table
pkg.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.