Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Use the BaseExecutorV2 to refactor the SelectionExec and remove the session context inside #54617

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #54616

Similar to #51397. This PR uses the BaseExecutorV2 and removed the session context in the SelectionExec.

What changed and how does it work?

  1. Remove the BaseExecutor internal and replace it with BaseExecutorV2.
  2. Add a new selectionExecutorContext, which includes all information needed by the selection executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      No logic change. It shouldn't break existing tests.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.1376%. Comparing base (0ad8b84) to head (8d5709e).
Report is 7 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54617         +/-   ##
=================================================
- Coverage   74.7414%   53.1376%   -21.6038%     
=================================================
  Files          1552       1669        +117     
  Lines        362891     604370     +241479     
=================================================
+ Hits         271230     321148      +49918     
- Misses        72048     259915     +187867     
- Partials      19613      23307       +3694     
Flag Coverage Δ
integration 36.8396% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 55.1994% <ø> (ø)
parser ∅ <ø> (∅)
br 48.4378% <ø> (+0.7623%) ⬆️

@YangKeao YangKeao requested a review from lcwangchao July 16, 2024 02:12
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 17, 2024
@YangKeao YangKeao requested a review from xhebox July 19, 2024 06:36
@YangKeao YangKeao force-pushed the support-selection branch from d93f2c2 to 8d5709e Compare July 19, 2024 06:40
Copy link

tiprow bot commented Jul 19, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 8d5709e link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
Copy link

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 03:28:50.522465026 +0000 UTC m=+410952.513406498: ☑️ agreed by lcwangchao.
  • 2024-07-19 07:08:15.731140055 +0000 UTC m=+596917.722081525: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 2da324d into pingcap:master Jul 19, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the BaseExecutor in SelectionExec
3 participants