planner: respect tidb_analyze_column_options when build analyze plan
#54240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Rustin170506
force-pushed
the
rustin-patch-sessionctx-stack1-analyze
branch
from
64d7b81 to
7bdc3c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54240 +/- ##
=================================================
- Coverage 74.7619% 56.1611% -18.6008%
=================================================
Files 1523 1645 +122
Lines 361410 613324 +251914
=================================================
+ Hits 270197 344450 +74253
- Misses 71584 245648 +174064
- Partials 19629 23226 +3597
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rustin170506
force-pushed
the
rustin-patch-sessionctx-stack1-analyze
branch
from
58d2dbd to
990c0d2
Compare
Rustin170506
changed the title
tidb_analyze_default_column_choice when build analyze plantidb_analyze_column_options when build analyze plan
Rustin170506
force-pushed
the
rustin-patch-sessionctx-stack1-analyze
branch
3 times, most recently
from
d4b15f6 to
b11f780
Compare
ti-chi-bot
bot
added
size/XL
Rustin170506
force-pushed
the
rustin-patch-sessionctx-stack1-analyze
branch
from
e5cd628 to
8efe30a
Compare
Rustin170506
commented
Jun 27, 2024
|
|
||
| // Analyze table. | ||
| tk.MustExec("analyze table t") | ||
| // FIXME: We should correct the job info or skip this kind of job. |
There was a problem hiding this comment.
I will fix this problem in my next PR.
| "Note 1105 Analyze use auto adjusted sample rate 1.000000 for table test.t, reason to use this rate is \"use min(1, 110000/10000) as the sample-rate=1\"", | ||
| ), | ||
| ) | ||
| // TODO: we should also include indexes in the job info. |
There was a problem hiding this comment.
I will improve it in my next PR.
…yze job Signed-off-by: hi-rustin <[email protected]> fix Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-sessionctx-stack1-analyze
branch
from
e8f1d72 to
d31c2d4
Compare
Rustin170506
commented
Jun 27, 2024
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
commented
Jun 27, 2024
Signed-off-by: hi-rustin <[email protected]>
qw4990
approved these changes
Jun 27, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
AilinKid
reviewed
Jun 28, 2024
AilinKid
reviewed
Jun 28, 2024
AilinKid
reviewed
Jun 28, 2024
| tk.MustExec("analyze table t") | ||
| // FIXME: We should correct the job info or skip this kind of job. | ||
| tk.MustQuery("select table_name, job_info from mysql.analyze_jobs order by id desc limit 1").Check( | ||
| testkit.Rows("t analyze table columns with 256 buckets, 100 topn, 1 samplerate"), |
There was a problem hiding this comment.
is that means all columns in L271's msg?
There was a problem hiding this comment.
This means we only analyzed the _row_id and updated the stats meta. I left a FIXME here, I will fix it in my next PR.
Co-authored-by: Arenatlx <[email protected]>
Rustin170506
commented
Jun 28, 2024
AilinKid
approved these changes
Jun 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #53567
This PR is based on #54200.
Problem Summary:
When
tidb_analyze_column_optionsis set toPREDICATE, we should only analyze predicate columns.What changed and how does it work?
tidb_analyze_default_column_choicewhen building the analyze plan.tidb_enable_column_tracking.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.