Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix flaky test TestTiDBTrx #53932

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 11, 2024

What problem does this PR solve?

Issue Number: close #53901

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2024
@hawkingrei hawkingrei changed the title * fix flaky test in the TestTiDBTrx * fix flaky test TestTiDBTrx Jun 11, 2024
@hawkingrei hawkingrei changed the title * fix flaky test TestTiDBTrx *: fix flaky test TestTiDBTrx Jun 11, 2024
@hawkingrei
Copy link
Member Author

/retest

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.8023%. Comparing base (fedf3b7) to head (375ef78).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53932         +/-   ##
=================================================
- Coverage   72.5455%   55.8023%   -16.7432%     
=================================================
  Files          1508       1628        +120     
  Lines        431744     602625     +170881     
=================================================
+ Hits         313211     336279      +23068     
- Misses        99128     243247     +144119     
- Partials      19405      23099       +3694     
Flag Coverage Δ
integration 37.1880% <ø> (?)
unit 71.5323% <ø> (-0.0028%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.7390% <ø> (+8.5922%) ⬆️

*
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 11, 2024
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw the purpose of this line of test needs some explanation in comments and better have a link to the issue #53026 . It took me some time to understand the purpose of this test...

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 11, 2024
Copy link

ti-chi-bot bot commented Jun 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-11 10:27:22.744400086 +0000 UTC m=+460396.797712024: ☑️ agreed by Defined2014.
  • 2024-06-11 11:35:38.077452665 +0000 UTC m=+464492.130764588: ☑️ agreed by MyonKeminta.

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, Defined2014, MyonKeminta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit ec6f56e into pingcap:master Jun 12, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53953.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 12, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #54573.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 11, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 26, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #54940.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestTiDBTrx
6 participants