server/tests/cursor: fix cursor fetch error flacky test (#50969) #53875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #50969
What problem does this PR solve?
Issue Number: close #47029
Problem Summary:
I finally found the root cause of this flacky test. It's easy to understand:
Success Path:
Execute
the statementFetch
the statement3.1. The
rowContainerReader
worker works in the background, and return the error specified by failpointFail Path:
Execute
the statementrowContainerReader
worker works in the background. At this time, the failpoint is still not enabled.Fetch
the result, but get no error.The
rowContainerReader
worker can run right afterExecute
command, because it has a channel buffer whose size is twice as the chunk size. By default, it's just 2048 (equals the whole table size in this test 🤦). Therefore, another fix of this issue is to increase the table size from 2048 to a higher value. But I choose to enable failpoint before executing the statement.What changed and how does it work?
Enable the failpoint before executing the statement, so that it'll definitely trigger the failpoint.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.