Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: fail backup when no tikv store #53783

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jun 4, 2024

What problem does this PR solve?

Issue Number: close #53784

Problem Summary:

What changed and how does it work?

If the cluster has 0 tikv replica, we should fail the backup directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jun 4, 2024
Copy link

tiprow bot commented Jun 4, 2024

Hi @BornChanger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger BornChanger added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 4, 2024
Signed-off-by: BornChanger <[email protected]>
@BornChanger BornChanger force-pushed the fail_ebs_backup_no_store branch from 4ca482c to d968420 Compare June 4, 2024 04:34
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.9004%. Comparing base (45318da) to head (d968420).
Report is 101 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53783         +/-   ##
=================================================
- Coverage   72.5218%   56.9004%   -15.6214%     
=================================================
  Files          1505       1630        +125     
  Lines        430498     618905     +188407     
=================================================
+ Hits         312205     352160      +39955     
- Misses        99118     242900     +143782     
- Partials      19175      23845       +4670     
Flag Coverage Δ
integration 38.4530% <0.0000%> (?)
unit 71.4265% <0.0000%> (-0.0826%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-1.0302%) ⬇️
parser ∅ <ø> (∅)
br 61.9862% <0.0000%> (+20.5617%) ⬆️

@BornChanger
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@BornChanger
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2024
@BornChanger
Copy link
Contributor Author

/cc @YuJuncen @WangLe1321

@ti-chi-bot ti-chi-bot bot requested review from WangLe1321 and YuJuncen June 6, 2024 12:43
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
Copy link

ti-chi-bot bot commented Jun 12, 2024

@WangLe1321: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
Copy link

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-12 04:22:35.494443871 +0000 UTC m=+524909.547755795: ☑️ agreed by 3pointer.
  • 2024-06-12 08:13:11.029103947 +0000 UTC m=+538745.082415872: ☑️ agreed by Leavrth.

Copy link

tiprow bot commented Jun 12, 2024

@BornChanger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow d968420 link true /test fast_test_tiprow
tidb_parser_test d968420 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit e785887 into pingcap:master Jun 12, 2024
34 of 40 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53963.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53964.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53965.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 22, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: backup against no tikv store is not failed
5 participants