-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs br: fail backup when no tikv store #53783
ebs br: fail backup when no tikv store #53783
Conversation
Signed-off-by: BornChanger <[email protected]>
Hi @BornChanger. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: BornChanger <[email protected]>
4ca482c
to
d968420
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53783 +/- ##
=================================================
- Coverage 72.5218% 56.9004% -15.6214%
=================================================
Files 1505 1630 +125
Lines 430498 618905 +188407
=================================================
+ Hits 312205 352160 +39955
- Misses 99118 242900 +143782
- Partials 19175 23845 +4670
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
/unhold |
/cc @YuJuncen @WangLe1321 |
@WangLe1321: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth, WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@BornChanger: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #53784
Problem Summary:
What changed and how does it work?
If the cluster has 0 tikv replica, we should fail the backup directly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.