Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: Don't log "received task config" in server mode (#52336) #53771

Merged
merged 3 commits into from
Jun 5, 2024
Merged

lightning: Don't log "received task config" in server mode (#52336) #53771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a25fab
This is an automated cherry-pick of #52336
kennytm Apr 3, 2024
e93f996
lightning: fix merge conflict
kennytm Jun 4, 2024
8023ab0
br: actually destroy the unused `sensitive.go`
kennytm Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions br/pkg/lightning/lightning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,8 +693,7 @@
writeJSONError(w, http.StatusBadRequest, "cannot read request", err)
return
}
filteredData := utils.HideSensitive(string(data))
log.L().Info("received task config", zap.String("content", filteredData))
log.L().Info("received task config")

Check warning on line 696 in br/pkg/lightning/lightning.go

View check run for this annotation

Codecov / codecov/patch

br/pkg/lightning/lightning.go#L696 

Added line #L696 was not covered by tests

cfg := config.NewConfig()
if err = cfg.LoadFromGlobal(l.globalCfg); err != nil {
Expand Down
4 changes: 1 addition & 3 deletions br/pkg/utils/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ go_library(
"retry.go",
"safe_point.go",
"schema.go",
"sensitive.go",
"store_manager.go",
"suspend_importing.go",
"worker.go",
Expand Down Expand Up @@ -86,11 +85,10 @@ go_test(
"retry_test.go",
"safe_point_test.go",
"schema_test.go",
"sensitive_test.go",
],
embed = [":utils"],
flaky = True,
shard_count = 33,
shard_count = 32,
deps = [
"//br/pkg/errors",
"//br/pkg/metautil",
Expand Down
23 changes: 0 additions & 23 deletions br/pkg/utils/sensitive.go
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions br/pkg/utils/sensitive_test.go
View file
Open in desktop

This file was deleted.

Loading