Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix small regression caused by #53094 #53646

Merged
merged 4 commits into from
May 29, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented May 29, 2024

What problem does this PR solve?

Issue Number: ref #50618

Problem Summary: planner: fix small regression caused by #53094

What changed and how does it work?

BenchmarkPreparedPointGet: 7020 ns/op --> 6528 ns/op

Skip GetMatchOpts and checkPreparedPriv for cached point-get plans

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2024
Copy link

tiprow bot commented May 29, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label May 29, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6041%. Comparing base (afd2343) to head (ebefac2).
Report is 1000 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53646        +/-   ##
================================================
+ Coverage   72.5370%   74.6041%   +2.0670%     
================================================
  Files          1506       1506                
  Lines        430741     431145       +404     
================================================
+ Hits         312447     321652      +9205     
+ Misses        98968      89572      -9396     
- Partials      19326      19921       +595     
Flag Coverage Δ
integration 49.1994% <88.4615%> (?)
unit 71.4742% <100.0000%> (-0.0554%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4980% <ø> (+8.6928%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-29 07:05:53.812717214 +0000 UTC m=+2846507.569852787: ☑️ agreed by hawkingrei.
  • 2024-05-29 08:20:16.707930383 +0000 UTC m=+2850970.465065990: ☑️ agreed by AilinKid.

Copy link

ti-chi-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 87999d1 into pingcap:master May 29, 2024
23 checks passed
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants