Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch some failpoints to InjectCall #53588

Merged
merged 3 commits into from
May 28, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented May 27, 2024

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

after pingcap/failpoint#83, we can update some failpoints in disttask/add-index/importinto by using InjectCall/EnableCall now, to avoid test code pollute main code

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2024
Copy link

tiprow bot commented May 27, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.9929%. Comparing base (e6d1899) to head (0a88c42).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53588        +/-   ##
================================================
+ Coverage   74.4090%   74.9929%   +0.5838%     
================================================
  Files          1505       1506         +1     
  Lines        357373     435337     +77964     
================================================
+ Hits         265918     326472     +60554     
- Misses        72128      88913     +16785     
- Partials      19327      19952       +625     
Flag Coverage Δ
integration 49.5259% <60.0000%> (?)
unit 71.9715% <80.0000%> (-1.3025%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.4912% <ø> (+7.4303%) ⬆️

@D3Hunter D3Hunter requested a review from lance6716 May 27, 2024 10:48
Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 28, 2024
Copy link

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-27 09:16:45.606791183 +0000 UTC m=+2681559.363926752: ☑️ agreed by tangenta.
  • 2024-05-28 02:28:23.753316146 +0000 UTC m=+2743457.510451719: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit d49a654 into pingcap:master May 28, 2024
23 checks passed
@D3Hunter D3Hunter deleted the change-fp branch May 28, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants