-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: speed up create table
and reduce memory usage when the number of tables is relatively large (#49371)
#53545
*: speed up create table
and reduce memory usage when the number of tables is relatively large (#49371)
#53545
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53545 +/- ##
================================================
Coverage ? 71.9860%
================================================
Files ? 1411
Lines ? 410299
Branches ? 0
================================================
Hits ? 295358
Misses ? 95065
Partials ? 19876
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
@3AceShowHand: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #49371
What problem does this PR solve?
Issue Number: close #49370
Problem Summary:
ListTables
took a lot of time when the number of tables was relatively largeWhat changed and how does it work?
Because the unmarshal of the
TableInfo
structure takes a large proportion of time, we only needn't all structures of theTableInfo
. So we useTableNameInfo
instead of it.Check List
Tests
Memory usage
Before this PR, when the 113k table is created, TiDB OOM (14G+) appears.
After this PR, the maximum memory of TiDB is nearly 6.9G when creating 113k tables, and the maximum memory usage is 11G when 400k tables are created
Time taken
Execute
checkTableNotExistsFromStore
function consumption of time.Master branch info:
After this PR info(The middle area is particularly high because the owner of another service is transferred):
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.