Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: load auto id related changes for multi-schema-change diff (#52967) #53473

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52967

What problem does this PR solve?

Issue Number: close #47899

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

for the case in the issue

mysql>  create table t (a int not null auto_increment primary key, b int) auto_id_cache 100;insert into t (b) values (1);
Query OK, 0 rows affected (0.09 sec)

Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+---+------+
| a | b    |
+---+------+
| 1 |    1 |
+---+------+
1 row in set (0.00 sec)

mysql> alter table t add column c int, auto_increment 200;
Query OK, 0 rows affected (0.31 sec)

mysql> insert into t (b) values (2);
Query OK, 1 row affected (0.01 sec)

mysql> select * from t;
+-----+------+------+
| a   | b    | c    |
+-----+------+------+
|   1 |    1 | NULL |
| 200 |    2 | NULL |
+-----+------+------+
2 rows in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 22, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 27, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 27, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2024
Copy link

ti-chi-bot bot commented May 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-27 09:50:14.708115148 +0000 UTC m=+2683568.465250706: ☑️ agreed by D3Hunter.
  • 2024-05-27 09:51:30.135953742 +0000 UTC m=+2683643.893089307: ☑️ agreed by Benjamin2037.

Copy link

ti-chi-bot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter
Copy link
Contributor

D3Hunter commented May 27, 2024

the coresponding change in mysql-test repo for this PR is https://github.com/PingCAP-QE/tidb-test/pull/2320 which changes the code of https://github.com/PingCAP-QE/tidb-test/pull/2230, but https://github.com/PingCAP-QE/tidb-test/pull/2230 is not in 7.5 branch, if we want to cp it, we have to cp this https://github.com/PingCAP-QE/tidb-test/pull/2320 too.

but the test in https://github.com/PingCAP-QE/tidb-test/pull/2230 is actually already covered in THIS very PR, i think we don't need to cp https://github.com/PingCAP-QE/tidb-test/pull/2230, so i will remove the | tidb-test=pr/2320 in the title

@D3Hunter D3Hunter changed the title infoschema: load auto id related changes for multi-schema-change diff | tidb-test=pr/2320 (#52967) infoschema: load auto id related changes for multi-schema-change diff (#52967) May 27, 2024
@D3Hunter
Copy link
Contributor

/retest

1 similar comment
@D3Hunter
Copy link
Contributor

/retest

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@33cae3a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53473   +/-   ##
================================================
  Coverage               ?   71.9947%           
================================================
  Files                  ?       1411           
  Lines                  ?     410408           
  Branches               ?          0           
================================================
  Hits                   ?     295472           
  Misses                 ?      95048           
  Partials               ?      19888           
Flag Coverage Δ
unit 71.9947% <76.1904%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4631% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit afe2aae into pingcap:release-7.5 May 27, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants