-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: do not reference owner_id for specific system DDL #53332
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53332 +/- ##
================================================
+ Coverage 74.4290% 74.4894% +0.0604%
================================================
Files 1497 1498 +1
Lines 356920 430892 +73972
================================================
+ Hits 265652 320969 +55317
- Misses 71938 89971 +18033
- Partials 19330 19952 +622
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #53327
Problem Summary:
In #53234, TiDB fails to execute below upgrade DDL, because it needs to access
owner_id
fromtidb_mdl_info
.What changed and how does it work?
For the DDLs related to system tables, we skip using
owner_id
field to prevent above DDL failed.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.