Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: skip MDL when analyzing table (#50928) | tidb-test=pr/2323 #53050

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50928

What problem does this PR solve?

Issue Number: close #47475

Problem Summary:

What changed and how does it work?

Skip lock if the statement is analyze stmt

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Analyze doesn't block DDL any more 

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230625-v6.5.3 labels May 7, 2024
Benjamin2037
Benjamin2037 previously approved these changes May 7, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 7, 2024
Remove conflict.
Solve conflict.
@wjhuang2016
Copy link
Member

/retest

Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 03:22:28.624988669 +0000 UTC m=+932302.382124243: ☑️ agreed by Benjamin2037.
  • 2024-05-09 06:08:02.07456157 +0000 UTC m=+1115035.831697143: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wjhuang2016
Copy link
Member

/retest

@wjhuang2016 wjhuang2016 changed the title planner: skip MDL when analyzing table (#50928) planner: skip MDL when analyzing table (#50928) | tidb-test=pr/2323 May 11, 2024
@wjhuang2016
Copy link
Member

/retest

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-6.5-20230625-v6.5.3@0695f1e). Click here to learn what that means.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20230625-v6.5.3     #53050   +/-   ##
================================================================
  Coverage                               ?   73.3983%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346467           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254301           
  Misses                                 ?      75729           
  Partials                               ?      16437           

@ti-chi-bot ti-chi-bot bot merged commit deeb433 into pingcap:release-6.5-20230625-v6.5.3 May 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230625-v6.5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants