-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/pdutils: retry when encountered dns error (#53005) #53032
br/pdutils: retry when encountered dns error (#53005) #53032
Conversation
close pingcap#53029 Signed-off-by: hillium <[email protected]>
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53032 +/- ##
================================================
Coverage ? 71.9865%
================================================
Files ? 1410
Lines ? 409503
Branches ? 0
================================================
Hits ? 294787
Misses ? 94871
Partials ? 19845
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: close #53029
Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses
No such host
which will abort the creation ofPDController
. We should retry this sort of error.What changed and how does it work?
This PR added retry when the
net.Error
isDNSError
.Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.