Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/pdutils: retry when encountered dns error (#53005) #53032

Merged

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented May 6, 2024

What problem does this PR solve?

Issue Number: close #53029

Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses No such host which will abort the creation of PDController. We should retry this sort of error.

What changed and how does it work?

This PR added retry when the net.Error is DNSError.
Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 6, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 6, 2024
Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 09:17:37.338652192 +0000 UTC m=+867211.095787763: ☑️ agreed by BornChanger.
  • 2024-05-06 09:18:43.526815619 +0000 UTC m=+867277.283951192: ☑️ agreed by 3pointer.

Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-7.5@61c4bd6). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53032   +/-   ##
================================================
  Coverage               ?   71.9865%           
================================================
  Files                  ?       1410           
  Lines                  ?     409503           
  Branches               ?          0           
================================================
  Hits                   ?     294787           
  Misses                 ?      94871           
  Partials               ?      19845           
Flag Coverage Δ
unit 71.9865% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3528% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit b562204 into pingcap:release-7.5 May 6, 2024
29 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants