Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: handle errors returned from Flush (#52890) #52961

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52890

What problem does this PR solve?

Issue Number: close #52889

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. label Apr 28, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@ekexium ekexium requested review from cfzjywxk and crazycs520 April 28, 2024 11:07
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@7d912d9). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52961   +/-   ##
================================================
  Coverage               ?   71.1378%           
================================================
  Files                  ?       1463           
  Lines                  ?     420395           
  Branches               ?          0           
================================================
  Hits                   ?     299060           
  Misses                 ?     100890           
  Partials               ?      20445           
Flag Coverage Δ
unit 71.1378% <60.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9483% <0.0000%> (?)

@ekexium ekexium requested a review from you06 April 29, 2024 04:04
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 07:33:47.916702285 +0000 UTC m=+256181.673837855: ☑️ agreed by MyonKeminta.
  • 2024-04-29 07:40:44.793734639 +0000 UTC m=+256598.550870212: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 015448e into pingcap:release-8.1 Apr 29, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants