Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: modify the printing of column default expression in SHOW CREATE TABLE and Restore (#52940) #52948

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52940

What problem does this PR solve?

Issue Number: close #52939

Problem Summary:

See the description of the issue.

What changed and how does it work?

If the column default expression is ast.FuncCallExpr except ast.CurrentTimestamp, wrap an outer parentheses in SHOW CREATE TABLE and Restore()

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Wrap some column default expressions within parentheses in SHOW CREATE TABLE and Restore

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Apr 28, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@CbcWestwolf CbcWestwolf force-pushed the cherry-pick-52940-to-release-6.1 branch from 117c13b to 00d1dbc Compare April 28, 2024 15:43
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 29, 2024
Copy link

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 29, 2024
Copy link

ti-chi-bot bot commented Apr 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 01:35:41.303634037 +0000 UTC m=+234695.060769608: ☑️ agreed by CbcWestwolf.
  • 2024-04-29 01:51:58.042531078 +0000 UTC m=+235671.799666651: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit f925e71 into pingcap:release-6.1 Apr 29, 2024
7 checks passed
@CbcWestwolf CbcWestwolf deleted the cherry-pick-52940-to-release-6.1 branch April 29, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants