planner: add a fix control to allow generate index merge path when normal index lookup path exists #52872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
time-and-fate
added
needs-cherry-pick-release-8.1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52872 +/- ##
=================================================
- Coverage 74.3919% 55.6878% -18.7042%
=================================================
Files 1482 1593 +111
Lines 355545 598150 +242605
=================================================
+ Hits 264497 333097 +68600
- Misses 71785 241987 +170202
- Partials 19263 23066 +3803
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
the
size/M
winoros
approved these changes
Apr 25, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
fixdb
reviewed
Apr 25, 2024
| drop table if exists t; | ||
| create table t(pk varbinary(255) primary key, a int, b varchar(50), c int, d varchar(45), index ia(a), index ib(b), index ic(c), index id(d)); | ||
| EXPLAIN format = brief SELECT /*+ use_index_merge(t) */ * FROM t WHERE a = 1 AND (b = '2' OR c = 3 OR d = '4'); | ||
| EXPLAIN format = brief SELECT * FROM t WHERE a = 1 AND (b = '2' OR c = 3 OR d = '4'); |
There was a problem hiding this comment.
Add more test cases like:
b = '2' OR c = 3 OR b = '3' OR c = 4
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
AilinKid
approved these changes
Apr 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
ti-chi-bot
bot
added
size/L
|
/retest |
|
/unhold |
ti-chi-bot
bot
added
release-note
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #52869
What changed and how does it work?
Simple change. Please see the issue and code.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.