linter, *: enable linters appends and unusedwrite

[YangKeao]

What problem does this PR solve?

Issue Number: close #52450, ref #52449

Problem Summary:

Enable two linters: appends and unusedwrite.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.
    Simple syntax change. They should already be covered by existing test.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-09 08:58:32.679443473 +0000 UTC m=+952774.206984015: ☑️ agreed by lance6716.
• 2024-04-09 09:01:43.249552651 +0000 UTC m=+952964.777093197: ☑️ agreed by hawkingrei.

[codecov]

Codecov Report

Merging #52452 (8d3e4d4) into master (1cec66b) will increase coverage by 3.4864%.
Report is 33 commits behind head on master.
The diff coverage is 16.6666%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52452        +/-   ##
================================================
+ Coverage   72.1268%   75.6133%   +3.4864%     
================================================
  Files          1467       1489        +22     
  Lines        426791     443062     +16271     
================================================
+ Hits         307831     335014     +27183     
+ Misses        99720      87064     -12656     
- Partials      19240      20984      +1744     

Flag	Coverage Δ
integration	52.0941% <8.3333%> (?)
unit	71.2578% <16.6666%> (+0.2605%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	61.7885% <ø> (+20.9361%)	⬆️

[hawkingrei]

/retest

[hawkingrei]

/retest

[hawkingrei]

/retest

[YuJuncen]

Why remove this ID？

[YangKeao]

Because it's not used in this test 🤔 .

[YuJuncen]

Well, that test passes. I guess this will probably be fine.

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, lance6716, YuJuncen, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YuJuncen,hawkingrei,lance6716,zimulala]
• br/OWNERS [YuJuncen]
• pkg/ddl/OWNERS [zimulala]
• pkg/planner/OWNERS [hawkingrei]
• pkg/sessionctx/variable/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[YangKeao]

/test pull-lightning-integration-test

[tiprow]

@YangKeao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.