disttask,ddl: use subtask concurrency #52286
Conversation
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
|
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52286 +/- ##
================================================
+ Coverage 72.8831% 73.3423% +0.4591%
================================================
Files 1468 1468
Lines 359618 434126 +74508
================================================
+ Hits 262101 318398 +56297
- Misses 78280 95831 +17551
- Partials 19237 19897 +660
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <[email protected]>
pkg/executor/importer/import.go
Outdated
| @@ -1309,6 +1309,7 @@ func (e *LoadDataController) getBackendWorkerConcurrency() int { | |||
| // IO intensive, so CPU usage is below ThreadCnt in our tests. | |||
| // The real concurrency used is adjusted in external engine later. | |||
| // when using local sort, use the default value as lightning. | |||
| // TODO(lance6716): can we remove this assignment branch? | |||
There was a problem hiding this comment.
i remember you have a pr to reduce range-concurrency of add-index, and it has no perf regression, maybe change it to e.ThreadCnt * 2 always here.
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #49008
Problem Summary:
What changed and how does it work?
DDL and IMPORT INTO use SubtaskBase.Concurrency. The downside is we cann't dynamically adjust the concurrency using tidb_ddl_reorg_worker_cnt for now.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.