executor: support Chunk for SelectionExec #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Nov 27, 2017
util/chunk/chunk.go
Outdated
| @@ -347,6 +347,11 @@ type Row struct { | |||
| idx int | |||
| } | |||
|
|
|||
| // ID returns the row index of Chunk. | |||
| func (r Row) ID() int { | |||
There was a problem hiding this comment.
I think we should use Idx for consistency.
|
@zz-jason |
|
/run-all-tests |
41 tasks
coocood
reviewed
Nov 29, 2017
expression/chunk_executor.go
Outdated
|
|
||
| // UnVectorizedFilter applys a list of filters to a Chunk and returns a bool slice, which indicates whether a row is passed the filters. | ||
| // Filters is not executed vectorized. | ||
| func UnVectorizedFilter(ctx context.Context, filters []Expression, input *chunk.Chunk, selected []bool) ([]bool, error) { |
There was a problem hiding this comment.
Our normal tests do not cover this, we should add a specific test case for it.
|
LGTM |
tiancaiamao
reviewed
Nov 30, 2017
executor/executor.go
Outdated
| chk.Reset() | ||
| for { | ||
| for ; e.inputRow != e.childrenResults[0].End(); e.inputRow = e.inputRow.Next() { | ||
| if e.batched { |
There was a problem hiding this comment.
I think you can split batch and non-batch logic into two different function.
Keep the function small and compact make the code more readable.
|
/run-all-tests |
|
@tiancaiamao PTAL again |
XuHuaiyu
reviewed
Nov 30, 2017
executor/executor.go
Outdated
| continue | ||
| } | ||
| chk.AppendRow(0, e.inputRow) | ||
| if chk.NumRows() == e.ctx.GetSessionVars().MaxChunkSize { |
There was a problem hiding this comment.
- move this check to line 610 thus line 612 can be removed.
- chk.reachMaxSize()
executor/executor.go
Outdated
| } | ||
| } | ||
|
|
||
| func (e *SelectionExec) unBatchedNextChunk(chk *chunk.Chunk) error { |
There was a problem hiding this comment.
add a comment for this func.
|
LGTM |
XuHuaiyu
added
status/LGT2
|
LGTM |
|
to #5261 |
XuHuaiyu
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.