Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs snapshot backup: remove checking store number (#51886) #51961

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51886

warn if store num not match

What problem does this PR solve?

Issue Number: close #51957

Problem Summary:
It is unnecessary to check the store number in data restore phase -- since tidb-operator will help us to check it.
Now this check breaks a workaround for one store cannot unexpectedly bootstrap after restoring.

What changed and how does it work?

This PR removes the check to number of stores.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    The change is tiny and I manually tested it in a local k8s cluster.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yu Juncen <[email protected]>

warn if store num not match

Signed-off-by: Yu Juncen <[email protected]>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 20, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 20, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 12:36:01.732815729 +0000 UTC m=+1466588.755062116: ☑️ agreed by YuJuncen.
  • 2024-03-20 12:56:31.86696149 +0000 UTC m=+1467818.889207875: ☑️ agreed by BornChanger.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@9ad6f42). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #51961   +/-   ##
================================================
  Coverage               ?   73.6362%           
================================================
  Files                  ?       1095           
  Lines                  ?     350842           
  Branches               ?          0           
================================================
  Hits                   ?     258347           
  Misses                 ?      75880           
  Partials               ?      16615           

@ti-chi-bot ti-chi-bot bot merged commit 183b430 into pingcap:release-6.5 Mar 20, 2024
27 of 28 checks passed
@BornChanger BornChanger changed the title log_backup: remove checking store number (#51886) ebs snapshot backup: remove checking store number (#51886) May 5, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 6, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
@BornChanger BornChanger added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 3, 2024
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-51961-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-51961-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-7.1: #57083.

@BornChanger BornChanger removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants