-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ebs snapshot backup: remove checking store number (#51886) #51961
ebs snapshot backup: remove checking store number (#51886) #51961
Conversation
Signed-off-by: Yu Juncen <[email protected]> warn if store num not match Signed-off-by: Yu Juncen <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #51961 +/- ##
================================================
Coverage ? 73.6362%
================================================
Files ? 1095
Lines ? 350842
Branches ? 0
================================================
Hits ? 258347
Misses ? 75880
Partials ? 16615 |
…) (pingcap#48) (pingcap#62) close pingcap#51957 Co-authored-by: Naman Gupta <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
…) (pingcap#48) close pingcap#51957 Co-authored-by: Ti Chi Robot <[email protected]>
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-51961-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-7.5 and ti-chi-bot:cherry-pick-51961-to-release-7.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} |
In response to a cherrypick label: new pull request created to branch |
This is an automated cherry-pick of #51886
warn if store num not match
What problem does this PR solve?
Issue Number: close #51957
Problem Summary:
It is unnecessary to check the store number in data restore phase -- since tidb-operator will help us to check it.
Now this check breaks a workaround for one store cannot unexpectedly bootstrap after restoring.
What changed and how does it work?
This PR removes the check to number of stores.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.