Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: check MDL when starting and committing pipelined txns #51794

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Mar 14, 2024

What problem does this PR solve?

Issue Number: ref #50215

Problem Summary:

What changed and how does it work?

Ensure MDL is ON when starting and committing pipelined txns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ekexium ekexium force-pushed the pipelined-dml-mdl branch from 6af28ea to 07b3e39 Compare March 14, 2024 13:14
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
Copy link

tiprow bot commented Mar 14, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ekexium ekexium requested review from cfzjywxk and you06 March 14, 2024 13:15
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #51794 (07b3e39) into master (a1cad29) will increase coverage by 2.0399%.
Report is 12 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51794        +/-   ##
================================================
+ Coverage   70.7470%   72.7870%   +2.0399%     
================================================
  Files          1476       1476                
  Lines        437518     437567        +49     
================================================
+ Hits         309531     318492      +8961     
+ Misses       108612      99043      -9569     
- Partials      19375      20032       +657     
Flag Coverage Δ
integration 48.8016% <0.0000%> (?)
unit 70.4950% <0.0000%> (-0.0738%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4484% <ø> (+5.5199%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024
Copy link

ti-chi-bot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MyonKeminta, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024
Copy link

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-15 04:17:52.439082791 +0000 UTC m=+1004699.461329179: ☑️ agreed by you06.
  • 2024-03-15 05:05:29.649846902 +0000 UTC m=+1007556.672093290: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot bot merged commit 1bac1d4 into pingcap:master Mar 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants