-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: add sampling logger #51741
Conversation
Signed-off-by: hi-rustin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
Tested locally, only two logs per minute
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51741 +/- ##
================================================
+ Coverage 72.4691% 72.7230% +0.2538%
================================================
Files 1474 1476 +2
Lines 363628 439964 +76336
================================================
+ Hits 263518 319955 +56437
- Misses 80708 99962 +19254
- Partials 19402 20047 +645
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Tested again:
|
Signed-off-by: hi-rustin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #50132
Problem Summary:
If table analysis fails or there are no tables to analyze, we need to avoid printing duplicate logs.
What changed and how does it work?
We have added a sampling logger that prints only two same logs within a minute. However, please note that we cannot keep creating the logger repeatedly. It is necessary to keep it as a singleton so that we can track the same log counts with the same logger. Otherwise, the logger won't function as intended.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.