-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execdetails: add statistical data of table scanning of TiFlash #51726
Conversation
Skipping CI for Draft Pull Request. |
Hi @JinheLin. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Don't merge this PR until pingcap/tipb#326 merged. |
/build |
/retest |
@JinheLin: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51726 +/- ##
=================================================
- Coverage 70.7883% 54.9019% -15.8865%
=================================================
Files 1476 1582 +106
Lines 438120 603895 +165775
=================================================
+ Hits 310138 331550 +21412
- Misses 108641 249310 +140669
- Partials 19341 23035 +3694
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test build |
@JinheLin: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
go.mod
Outdated
@@ -318,6 +318,8 @@ replace ( | |||
github.com/go-ldap/ldap/v3 => github.com/YangKeao/ldap/v3 v3.4.5-0.20230421065457-369a3bab1117 | |||
github.com/pingcap/tidb/pkg/parser => ./pkg/parser | |||
|
|||
github.com/pingcap/tipb => github.com/JinheLin/tipb v0.0.0-20240313013727-f85f989ac0d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this PR until pingcap/tipb#326 merged and update tipb module after pingcap/tipb#326 merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. I think the name of the field should be carefully chosen, in order to keep readable, avoid ambiguity but also be short.
ac496d0
to
46d4e06
Compare
/retest |
Co-authored-by: Wenxuan <[email protected]>
Co-authored-by: Wenxuan <[email protected]>
Co-authored-by: Wenxuan <[email protected]>
Co-authored-by: Wenxuan <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
7ea2b12
to
b14ec51
Compare
/unhold |
/retest |
/cherry-pick release-7.5 |
Signed-off-by: ti-chi-bot <[email protected]>
@JaySon-Huang: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: ref #51727
Problem Summary:
What changed and how does it work?
Check List
Tests
explain analyze
to check the details of TableScanning.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.