-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txn: produce warnings when fallback from bulk mode #51697
txn: produce warnings when fallback from bulk mode #51697
Conversation
Signed-off-by: ekexium <[email protected]>
Hi @ekexium. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little concern.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51697 +/- ##
================================================
+ Coverage 70.7165% 72.3326% +1.6160%
================================================
Files 1473 1475 +2
Lines 437056 443277 +6221
================================================
+ Hits 309071 320634 +11563
+ Misses 108613 102326 -6287
- Partials 19372 20317 +945
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
…nfig Signed-off-by: ekexium <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: ekexium <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #50215
Problem Summary:
What changed and how does it work?
Produce warnings when we have to fallback to standard mode if
tidb_dml_type=bulk
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.