-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsql: use a more accurate type of the context of distsql #51618
Conversation
Skipping CI for Draft Pull Request. |
Skipping CI for Draft Pull Request. |
/retest |
5b19b9e
to
463105d
Compare
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51618 +/- ##
================================================
- Coverage 70.7391% 70.7205% -0.0186%
================================================
Files 1491 1563 +72
Lines 440448 460337 +19889
================================================
+ Hits 311569 325553 +13984
- Misses 109378 114159 +4781
- Partials 19501 20625 +1124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
463105d
to
1526135
Compare
/retest |
1526135
to
48c8112
Compare
/retest |
48c8112
to
79669c2
Compare
/retest |
1 similar comment
/retest |
1d19298
to
c1bec69
Compare
/retest |
c1bec69
to
ba4717a
Compare
/retest |
5f41f42
to
fd4b52f
Compare
fd4b52f
to
4e7a8f9
Compare
/retest |
4e7a8f9
to
06eec5f
Compare
06eec5f
to
8c41e7f
Compare
[LGTM Timeline notifier]Timeline:
|
8c41e7f
to
902a01b
Compare
902a01b
to
b0c1857
Compare
Signed-off-by: Yang Keao <[email protected]>
b0c1857
to
c201821
Compare
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, XuHuaiyu, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #51617
Problem Summary:
The
distsql
only needs a subset of the whole session variables and context, so we can use a more accurate type to represent it. This refactor will help us to clone it in the future.What changed and how does it work?
DistSQLContext
, which contains all information needed by the session.StmtCtx
, because the cache should be invalidated after each execution.stmtctx
(and session, maybe) fromdistsql
.Check List
Tests
Side effects
Documentation
Release note