Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importinto: fix incorrect index kv group count when table have common handle #51615

Merged
merged 1 commit into from
Mar 8, 2024
Merged

importinto: fix incorrect index kv group count when table have common handle #51615

merged 1 commit into from
Mar 8, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 8, 2024

What problem does this PR solve?

Issue Number: ref #50752

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 8, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lance6716
lance6716 reviewed Mar 8, 2024
View reviewed changes
pkg/disttask/importinto/encode_and_sort_operator_test.go
numOfIndexGenKV: 4,
dataKVMemSizePerCon: 460175067,
perIndexKVMemSizePerCon: 153391689,
},
{
createSQL: "create table t (a int, b int, c int, primary key(a,b,c) nonclustered, key(b,c), unique(b), unique(c), key(a,b))",
Copy link
Contributor

@lance6716 lance6716 Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it cover the ClusteredIndexDefModeIntOnly? check with that option and a table with non-int PK

Copy link
Contributor Author

@D3Hunter D3Hunter Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// ClusteredIndexDefModeIntOnly indicates only single int primary key will default be clustered.

seems not related, composite clustered int pk is also CommonHandle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I see that HasClusteredIndex can both check t.PKIsHandle || t.IsCommonHandle

@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

Merging #51615 (fbe952c) into master (33d6b79) will increase coverage by 0.3667%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #51615        +/-   ##
================================================
+ Coverage   72.5226%   72.8893%   +0.3667%     
================================================
  Files          1468       1468                
  Lines        363168     437227     +74059     
================================================
+ Hits         263379     318692     +55313     
- Misses        80443      98572     +18129     
- Partials      19346      19963       +617
Flag Coverage Δ
integration 48.9861% <100.0000%> (?)
unit 70.5629% <100.0000%> (-1.8338%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.5295% <ø> (+5.0735%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 8, 2024
GMHDBJD
GMHDBJD approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 05:54:33.708340799 +0000 UTC m=+405700.730587185: ☑️ agreed by lance6716.
  • 2024-03-08 05:57:40.212487128 +0000 UTC m=+405887.234733516: ☑️ agreed by GMHDBJD.

Benjamin2037
Benjamin2037 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b55c855 into pingcap:master Mar 8, 2024
23 checks passed
@D3Hunter D3Hunter deleted the fix-get-idx branch March 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @lance6716 @Benjamin2037 @GMHDBJD