Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, tests: add expression default values feature relevant tests for some DDLs and fix a related bug #51571

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 7, 2024

What problem does this PR solve?

Issue Number: close #51554, close #51570

Problem Summary:

What changed and how does it work?

  • Add expression default values feature relevant tests for "modify column", "set/drop default" and "add index"
  • When the default value is an expression, changing it to a constant by "set default" can be problematic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 7, 2024
Copy link

tiprow bot commented Mar 7, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #51571 (7de105a) into master (b2c3e67) will increase coverage by 1.4857%.
Report is 49 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51571        +/-   ##
================================================
+ Coverage   70.7440%   72.2297%   +1.4857%     
================================================
  Files          1464       1471         +7     
  Lines        435644     447615     +11971     
================================================
+ Hits         308192     323311     +15119     
+ Misses       108146     104014      -4132     
- Partials      19306      20290       +984     
Flag Coverage Δ
integration 48.8458% <100.0000%> (?)
unit 70.5237% <100.0000%> (-0.0191%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5197% <ø> (+4.7065%) ⬆️

@zimulala
Copy link
Contributor Author

zimulala commented Mar 7, 2024

/test check-dev2

@pingcap pingcap deleted a comment from ti-chi-bot bot Mar 7, 2024
Copy link

tiprow bot commented Mar 7, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 11, 2024
Copy link

ti-chi-bot bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2024
Copy link

ti-chi-bot bot commented Mar 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-11 02:43:38.000511232 +0000 UTC m=+653445.022757634: ☑️ agreed by Defined2014.
  • 2024-03-11 02:46:49.578654849 +0000 UTC m=+653636.600901239: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 1e5c179 into pingcap:master Mar 11, 2024
23 checks passed
@zimulala zimulala deleted the zimuxia/expr-test1 branch March 11, 2024 06:09
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 12, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52582.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.5 from head ti-chi-bot:cherry-pick-51571-to-release-7.5: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 98EE:21F144:4FFBAF3:80C0803:6639C131 and timestamp 2024-05-07 05:50:41 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 7, 2024
@zimulala zimulala removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 20, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53394.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 20, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
4 participants