Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: store the updated labels into etcd (#51451) #51564

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51451

What problem does this PR solve?

Issue Number: close #51427

Problem Summary:

What changed and how does it work?

Update the latest labels to etcd when label api is called.

Check List

Tests

  • Unit test
  • [] Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Ran the case described in the issue now got:

~ » curl 127.0.0.1:10080/info/all
{
...
   "labels": {},
...
}%
----------------------------------------------------------------------------------
~ » curl -X POST -d "{\"foo\": \"bar\"}" 127.0.0.1:10080/labels
{
 "foo": "bar"
}%
----------------------------------------------------------------------------------
~ » curl 127.0.0.1:10080/info/all
{
...
   "labels": {
    "foo": "bar"
   },
...
 }
}%
----------------------------------------------------------------------------------
~ » curl -X POST -d "{\"foo\": \"tidb\"}" 127.0.0.1:10080/labels                                                                                                                                                                                               you06@you06s-MBP
{
 "foo": "tidb"
}%
----------------------------------------------------------------------------------
~ » curl 127.0.0.1:10080/info/all
{
...
   "labels": {
    "foo": "tidb"
   },
...
}%

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-51451-to-release-7.1 branch from f5d58bc to e86a505 Compare March 7, 2024 01:51
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 7, 2024
Signed-off-by: you06 <[email protected]>
@you06 you06 requested review from glorv and hawkingrei March 7, 2024 05:49
@you06
Copy link
Contributor

you06 commented Mar 7, 2024

/retest

Signed-off-by: you06 <[email protected]>
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@1dc6edf). Click here to learn what that means.
The diff coverage is 54.5454%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51564   +/-   ##
================================================
  Coverage               ?   73.4423%           
================================================
  Files                  ?       1212           
  Lines                  ?     379537           
  Branches               ?          0           
================================================
  Hits                   ?     278741           
  Misses                 ?      82993           
  Partials               ?      17803           

Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 7, 2024
@you06
Copy link
Contributor

you06 commented Mar 7, 2024

/merge

Copy link

ti-chi-bot bot commented Mar 7, 2024

@you06: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06
Copy link
Contributor

you06 commented Mar 7, 2024

/approve

@you06
Copy link
Contributor

you06 commented Mar 7, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao, you06, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lcwangchao,you06,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 07:20:00.796206435 +0000 UTC m=+324427.818452823: ☑️ agreed by hawkingrei.
  • 2024-03-07 07:43:55.100752151 +0000 UTC m=+325862.122998540: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit a8b650f into pingcap:release-7.1 Mar 7, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants