-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix TTL cannot split tasks with right ranges for common handle int (#51532) #51544
ttl: fix TTL cannot split tasks with right ranges for common handle int (#51532) #51544
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #51544 +/- ##
================================================
Coverage ? 73.4441%
================================================
Files ? 1212
Lines ? 379573
Branches ? 0
================================================
Hits ? 278774
Misses ? 83004
Partials ? 17795 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #51532
What problem does this PR solve?
Issue Number: close #51527
What changed and how does it work?
If a table has a primary key with common handle, we should use
kv.CommonHanlde
to decode the region edges even if the row type is integer.Check List
Tests
I tested this PR by re-execute the SQL in the issue, all tasks have rows to delete:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.