infoschema: tiny refactor, split v1 and v2 functions for applyDiff

[tiancaiamao]

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

We need to implement applyDiff for infoschema v2, here is a tiny refactor:

This kind of function signature means it supports both v1 and v2:

func applyXXX(b *Builder, m *meta.Meta, diff *model.SchemaDiff)

This kind of method signature applyXXX means it's for v1:

func (b *Builder) applyXXX(m *meta.Meta, diff *model.SchemaDiff)

This kind of method signature applyXXXV2 means it's for v2:

func (b *Builder) applyXXXV2(m *meta.Meta, diff *model.SchemaDiff)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

No logic changes, just the naming convention.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #51521 (9b68cb4) into master (0878b15) will increase coverage by 2.0682%.
Report is 1 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51521        +/-   ##
================================================
+ Coverage   70.7761%   72.8444%   +2.0682%     
================================================
  Files          1464       1464                
  Lines        435863     435984       +121     
================================================
+ Hits         308487     317590      +9103     
+ Misses       108058      98411      -9647     
- Partials      19318      19983       +665     

Flag	Coverage Δ
integration	48.8806% <29.5454%> (?)
unit	70.5125% <50.0000%> (-0.0639%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.4872% <ø> (+5.5957%)	⬆️

[tiancaiamao]

/test check-dev

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[GMHDBJD]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-05 10:52:28.20947548 +0000 UTC m=+164375.231721867: ☑️ agreed by ywqzzy.
• 2024-03-06 06:37:09.337086722 +0000 UTC m=+235456.359333111: ☑️ agreed by GMHDBJD.

[GMHDBJD]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/infoschema/OWNERS [GMHDBJD,ywqzzy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment