statistics: do not analyze table when auto analyze ratio is 0 #51467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <[email protected]>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: hi-rustin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51467 +/- ##
================================================
+ Coverage 70.7288% 72.8187% +2.0899%
================================================
Files 1462 1462
Lines 435268 435293 +25
================================================
+ Hits 307860 316975 +9115
+ Misses 108130 98376 -9754
- Partials 19278 19942 +664
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: hi-rustin <[email protected]>
ti-chi-bot
bot
added
size/L
Signed-off-by: hi-rustin <[email protected]>
AilinKid
approved these changes
Mar 4, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #50132
Problem Summary:
What changed and how does it work?
There are two configurations for the auto-analyze feature that are very easy to misunderstand.
tidb_enable_auto_analyze: Determines whether TiDB automatically updates table statistics as a background operation.tidb_auto_analyze_ratio: This variable is used to set the threshold when TiDB automatically executes ANALYZE TABLE in a background thread to update table statistics. It is possible for the value to be 0, which means auto analysis based on the change percentage will be turned off. However, new tables and indexes will still be analyzed.So in the new implementation, I forgot it.
In this PR, I added a check for auto-analyze ratio and also added a test case to cover it.
Off-topic: I also updated
TestPickOneTableAndAnalyzeByPriorityto use the real API to do the analysis instead of inserting jobs directly.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.