Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix parallel apply wrong result #51414

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

guo-shaoge
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #51372

Problem Summary:

  1. Parallel apply needs to copy innerPlan of original PhysicalApply
  2. The Clone method of PhysicalIndexLookupReader didn't copy CommonHandleCols, which cause the cloned innerPlan got wrong CommonHandle info, which cause IndexLookup return wrong result

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix parallel apply got wrong result

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-title size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 29, 2024
Copy link

tiprow bot commented Feb 29, 2024

Hi @guo-shaoge. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guo-shaoge guo-shaoge changed the title fix parallel apply wrong result *: fix parallel apply wrong result Feb 29, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #51414 (fcae023) into master (33d7a2c) will increase coverage by 2.2312%.
Report is 19 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51414        +/-   ##
================================================
+ Coverage   70.6491%   72.8803%   +2.2312%     
================================================
  Files          1461       1462         +1     
  Lines        434876     440573      +5697     
================================================
+ Hits         307236     321091     +13855     
+ Misses       108368      99483      -8885     
- Partials      19272      19999       +727     
Flag Coverage Δ
integration 49.0012% <0.0000%> (?)
unit 70.3717% <100.0000%> (-0.0705%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2943% <ø> (+5.4155%) ⬆️

@guo-shaoge guo-shaoge requested a review from qw4990 February 29, 2024 07:54
@guo-shaoge
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Feb 29, 2024

@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 29, 2024
Copy link

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-29 07:04:33.443105815 +0000 UTC m=+1118362.190728927: ☑️ agreed by wshwsh12.
  • 2024-02-29 10:15:09.505582585 +0000 UTC m=+1129798.253205696: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit ac7dad3 into pingcap:master Feb 29, 2024
23 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 29, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51428.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51429.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 29, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51430.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 29, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Mar 7, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #51591.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel apply got wrong result when there are multiple columns as primary key
4 participants