-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix issue of get default value from column when column doesn't have default value (#51309) #51391
table: fix issue of get default value from column when column doesn't have default value (#51309) #51391
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test mysql-test |
@crazycs520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@crazycs520: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #51391 +/- ##
================================================
Coverage ? 73.6616%
================================================
Files ? 1095
Lines ? 350743
Branches ? 0
================================================
Hits ? 258363
Misses ? 75788
Partials ? 16592 |
This is an automated cherry-pick of #51309
What problem does this PR solve?
Issue Number: close #50043, close #51324
Problem Summary:
What changed and how does it work?
This PR reverts some changes introduced by #35072 and use another way to check
ErrNoDefaultValue
before insert.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.