Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: fix issue of get default value from column when column doesn't have default value (#51309) #51386

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 28, 2024

This is an automated cherry-pick of #51309

What problem does this PR solve?

Issue Number: close #50043, close #51324

Problem Summary:

What changed and how does it work?

This PR reverts some changes introduced by #35072 and use another way to check ErrNoDefaultValue before insert.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix issue of get wrong default value of column when column doesn't have default value

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. labels Feb 28, 2024
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Feb 28, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 28, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 28, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-28 06:23:34.978225247 +0000 UTC m=+1029503.725848360: ☑️ agreed by lcwangchao.
  • 2024-02-28 06:23:41.064100614 +0000 UTC m=+1029509.811723726: ☑️ agreed by Defined2014.

@crazycs520 crazycs520 changed the title table: fix issue of get default value from column when column doesn't have default value | tidb-test=pr/2305 (#51309) table: fix issue of get default value from column when column doesn't have default value (#51309) | tidb-test=pr/2305 Feb 28, 2024
@crazycs520 crazycs520 changed the title table: fix issue of get default value from column when column doesn't have default value (#51309) | tidb-test=pr/2305 table: fix issue of get default value from column when column doesn't have default value (#51309) Feb 28, 2024
@crazycs520
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Feb 28, 2024

@crazycs520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@8018155). Click here to learn what that means.
The diff coverage is 93.9393%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51386   +/-   ##
================================================
  Coverage               ?   73.4196%           
================================================
  Files                  ?       1211           
  Lines                  ?     379378           
  Branches               ?          0           
================================================
  Hits                   ?     278538           
  Misses                 ?      83050           
  Partials               ?      17790           

@ti-chi-bot ti-chi-bot bot merged commit 7b2d727 into pingcap:release-7.1 Feb 28, 2024
9 checks passed
@crazycs520 crazycs520 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 28, 2024
@crazycs520 crazycs520 added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Feb 28, 2024
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-7.5: #51388.

@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-6.5: #51389.

ti-chi-bot added a commit to ti-chi-bot/tidb that referenced this pull request Feb 28, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants