Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix flaky test TestPhysicalTableScanExtractCorrelatedCols #51355

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Feb 27, 2024

What problem does this PR solve?

Issue Number: close #51289

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
Copy link

tiprow bot commented Feb 27, 2024

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #51355 (1be229c) into master (6f02e99) will increase coverage by 2.2443%.
Report is 6 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51355        +/-   ##
================================================
+ Coverage   70.5756%   72.8200%   +2.2443%     
================================================
  Files          1462       1461         -1     
  Lines        434885     435505       +620     
================================================
+ Hits         306923     317135     +10212     
+ Misses       108661      98456     -10205     
- Partials      19301      19914       +613     
Flag Coverage Δ
integration 49.2506% <0.0000%> (?)
unit 70.3866% <100.0000%> (+0.0179%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4246% <ø> (+5.6017%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 09:21:18.231083273 +0000 UTC m=+953766.978706378: ☑️ agreed by hawkingrei.
  • 2024-02-27 09:24:54.361067065 +0000 UTC m=+953983.108690174: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot bot merged commit 49fcf49 into pingcap:master Feb 27, 2024
22 of 23 checks passed
@Lloyd-Pottiger
Copy link
Contributor Author

/cherry-pick-release-7.5

@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-flaky-test branch February 27, 2024 11:32
@Lloyd-Pottiger
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: new pull request created to branch release-7.5: #51377.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky case TestPhysicalTableScanExtractCorrelatedCols
4 participants