Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add generics lfu #51352

Closed
wants to merge 5 commits into from
Closed

util: add generics lfu #51352

wants to merge 5 commits into from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 27, 2024

What problem does this PR solve?

Issue Number: ref #51347

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei marked this pull request as draft February 27, 2024 08:01
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #51352 (8f1a5cb) into master (6f02e99) will increase coverage by 1.6571%.
Report is 12 commits behind head on master.
The diff coverage is n/a.

❗ Current head 8f1a5cb differs from pull request most recent head 23a1659. Consider uploading reports for the commit 23a1659 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51352        +/-   ##
================================================
+ Coverage   70.5756%   72.2328%   +1.6571%     
================================================
  Files          1462       1462                
  Lines        434885     434927        +42     
================================================
+ Hits         306923     314160      +7237     
+ Misses       108661     100813      -7848     
- Partials      19301      19954       +653     
Flag Coverage Δ
integration 27.9430% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3683% <ø> (+5.5454%) ⬆️

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei marked this pull request as ready for review February 27, 2024 15:38
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked labels Feb 27, 2024
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Copy link

tiprow bot commented Feb 28, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 23a1659 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Feb 28, 2024

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 23a1659 link true /test build
idc-jenkins-ci-tidb/unit-test 23a1659 link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 23a1659 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 23a1659 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 23a1659 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hawkingrei hawkingrei closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant