importinto: remove separate wait routine in detached mode and refactor

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

• remove separate wait routine in detached mode, move FlushTableStats callsite before FinishJob
• remove some legacy code

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #51335 (f156197) into master (23190ff) will increase coverage by 2.2921%.
Report is 8 commits behind head on master.
The diff coverage is 71.4285%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51335        +/-   ##
================================================
+ Coverage   70.6063%   72.8984%   +2.2921%     
================================================
  Files          1460       1462         +2     
  Lines        434692     439455      +4763     
================================================
+ Hits         306920     320356     +13436     
+ Misses       108493      99015      -9478     
- Partials      19279      20084       +805     

Flag	Coverage Δ
integration	49.0648% <68.2539%> (?)
unit	70.3531% <22.2222%> (-0.0436%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.2843% <ø> (+5.4299%)	⬆️

[lance6716]

rest lgtm

[lance6716]

In which case we will reach this branch? please add comments

[D3Hunter]

i think it's quite clear from the code that it's when disttask is not enabled

[GMHDBJD]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [GMHDBJD,lance6716]
• pkg/disttask/OWNERS [GMHDBJD,lance6716]
• pkg/executor/importer/OWNERS [GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-27 07:43:43.557668815 +0000 UTC m=+947912.305291921: ☑️ agreed by lance6716.
• 2024-02-27 08:09:01.45457425 +0000 UTC m=+949430.202197552: ☑️ agreed by GMHDBJD.