-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support (Row(..),Row(..))=>(..) in the binding mode #51319
Conversation
/check-issue-triage-complete |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51319 +/- ##
================================================
+ Coverage 70.6318% 72.3933% +1.7614%
================================================
Files 1460 1462 +2
Lines 434706 439089 +4383
================================================
+ Hits 307041 317871 +10830
+ Misses 108410 101171 -7239
- Partials 19255 20047 +792
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
normalized string | ||
digest string | ||
}{ | ||
{"select 1 from b where (x,y) in ((1, 3), ('3', 1))", "select ? from `b` where row ( `x` , `y` ) in ( ... )", "ab6c607d118c24030807f8d1c7c846ec23e3b752fd88ed763bb8e26fbfa56a83"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just replace literal with ?
? such as "select ? from b where (x,y) in ((?, ?), (?, ?))
, should be simplier to implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not binding mode. In binding mode, It must be select ? from b where (x,y) in (...)
.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, elsa0520, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
It seems like you haven't considered the compatibility issues when upgrading. |
What problem does this PR solve?
Issue Number: close #51222
Problem Summary:
What changed and how does it work?
before bugfix, process looks like this.
so we cannot bind the SQL with In ((..),(..))
after bugfix. it can work.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.