Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: use the correct last update version #51287

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #50132

Problem Summary:

What changed and how does it work?

There are two versions here:

  1. Version: The last stats update version(count and modify_count).
  2. LastUpdateVersion: The last update time of the histogram. We can take it as the last analysis time.

We should use the second one here instead of the first one.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2024
@Rustin170506 Rustin170506 changed the title fix: use correct last update version statistics: use correct last update version Feb 23, 2024
@Rustin170506 Rustin170506 changed the title statistics: use correct last update version WIP: statistics: use correct last update version Feb 23, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #51287 (61520f7) into master (f4e758a) will decrease coverage by 16.1122%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51287         +/-   ##
=================================================
- Coverage   70.6793%   54.5672%   -16.1122%     
=================================================
  Files          1460       1569        +109     
  Lines        434615     603432     +168817     
=================================================
+ Hits         307183     329276      +22093     
- Misses       108242     251231     +142989     
- Partials      19190      22925       +3735     
Flag Coverage Δ
integration 36.6186% <ø> (?)
unit 70.3553% <100.0000%> (-0.1192%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3955% <ø> (+5.5117%) ⬆️

@Rustin170506 Rustin170506 changed the title WIP: statistics: use correct last update version statistics: use correct last update version Feb 26, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
@Rustin170506 Rustin170506 force-pushed the rustin-patch-analyze-duration branch from f1654fb to 88ae6fb Compare February 27, 2024 02:22
Signed-off-by: hi-rustin <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
@Rustin170506
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 06:03:32.865702133 +0000 UTC m=+855501.613325245: ☑️ agreed by hawkingrei.
  • 2024-02-27 06:13:03.400284551 +0000 UTC m=+942472.147907662: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit 801de42 into pingcap:master Feb 27, 2024
23 checks passed
@Rustin170506 Rustin170506 changed the title statistics: use correct last update version statistics: use the correct last update version Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants