Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: join resolveIndex won't find its column and amend join's l/rused logic for reversed column ref from join schema to its children #51282

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51203

What problem does this PR solve?

Issue Number: close #42588

Problem Summary:

What changed and how does it work?

issue #42588 is caused by many factors and this pr is try to resolve them all.

join schema[col11, col22, col21], child1 [col1], child2 [col21, col22]
the pull/45831 make an assumption here that join schema won't refer a column-order revered from the order of its children. Like here [col22, col21] in join schema is reversed with  [col21, col22] from its child2. Step2 try to fix this.

in the execution layer.
join schema[col11, col22, col21], child1 [col1], child2 [col21, col22]
the lused will be [true]
the rused will be [true, true]
when constructing the join row result, the order couldn't be restored from a simple bool array. Consequently one join result will be shown like: <col1, col21, col22> while the field type is totally different from what the datum in the same position. So step3 try to fix this.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 23, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Feb 23, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, fixdb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 08:05:51.439038727 +0000 UTC m=+862840.186661838: ☑️ agreed by fixdb.
  • 2024-02-27 08:30:05.281655436 +0000 UTC m=+950694.029278549: ☑️ agreed by AilinKid.

@AilinKid
Copy link
Contributor

/retest

Signed-off-by: AilinKid <[email protected]>
@AilinKid AilinKid changed the title planner,executor: fix join resolveIndex won't find its column from children schema & amend join's lused and rused logic for reversed column ref from join schema to its children (#51203) planner: fix join resolveIndex won't find its column from children schema & amend join's lused and rused logic for reversed column ref from join schema to its children (#51203) Feb 27, 2024
@AilinKid AilinKid changed the title planner: fix join resolveIndex won't find its column from children schema & amend join's lused and rused logic for reversed column ref from join schema to its children (#51203) planner: fix join resolveIndex won't find its column from children schema and amend join's lused and rused logic for reversed column ref from join schema to its children (#51203) Feb 27, 2024
@AilinKid AilinKid changed the title planner: fix join resolveIndex won't find its column from children schema and amend join's lused and rused logic for reversed column ref from join schema to its children (#51203) planner: join resolveIndex won't find its column and amend join's l/rused logic for reversed column ref from join schema to its children Feb 27, 2024
.
Signed-off-by: AilinKid <[email protected]>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@ff7d92f). Click here to learn what that means.
The diff coverage is 75.1445%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #51282   +/-   ##
================================================
  Coverage               ?   73.4102%           
================================================
  Files                  ?       1210           
  Lines                  ?     379064           
  Branches               ?          0           
================================================
  Hits                   ?     278272           
  Misses                 ?      83004           
  Partials               ?      17788           

@ti-chi-bot ti-chi-bot bot merged commit fdac2a6 into pingcap:release-7.1 Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants