Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: move backend register from backfillDistExecutor to its StepExecutor #51247

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 22, 2024

What problem does this PR solve?

Issue Number: ref #50752

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

    pass existing tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2024
Copy link

tiprow bot commented Feb 22, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy
Copy link
Contributor

ywqzzy commented Feb 22, 2024

#50744

@ywqzzy ywqzzy self-requested a review February 22, 2024 09:04
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #51247 (6a65c54) into master (9ee46d4) will decrease coverage by 15.9315%.
Report is 3 commits behind head on master.
The diff coverage is 72.6315%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51247         +/-   ##
=================================================
- Coverage   70.5917%   54.6602%   -15.9315%     
=================================================
  Files          1467       1577        +110     
  Lines        435011     602505     +167494     
=================================================
+ Hits         307082     329331      +22249     
- Misses       108658     250247     +141589     
- Partials      19271      22927       +3656     
Flag Coverage Δ
integration 36.8117% <71.5789%> (?)
unit 70.3261% <2.1052%> (-0.0646%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3833% <ø> (+5.4953%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
@lance6716
Copy link
Contributor Author

ping @ywqzzy

Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 09:55:19.965797802 +0000 UTC m=+523808.713420913: ☑️ agreed by tangenta.
  • 2024-02-22 10:32:31.063970456 +0000 UTC m=+526039.811593567: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot bot merged commit 93e6a23 into pingcap:master Feb 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants