Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: unify task order naming to 'rank' & refactor failpoint #51136

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

  • unify task order naming to rank to different with priority field
  • some refactor on failpoint enable

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Sorry, something went wrong.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 19, 2024
Copy link

tiprow bot commented Feb 19, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter D3Hunter changed the title disttask: unify task order naming & refactor failpoint disttask: unify task order naming to 'rank' & refactor failpoint Feb 19, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 19, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #51136 (9c80392) into master (a465300) will decrease coverage by 15.8457%.
Report is 16 commits behind head on master.
The diff coverage is 91.6666%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51136         +/-   ##
=================================================
- Coverage   70.6268%   54.7812%   -15.8457%     
=================================================
  Files          1467       1576        +109     
  Lines        434809     604629     +169820     
=================================================
+ Hits         307092     331223      +24131     
- Misses       108517     250426     +141909     
- Partials      19200      22980       +3780     
Flag Coverage Δ
integration 37.0967% <71.4285%> (?)
unit 70.3190% <91.6666%> (-0.1129%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-0.0313%) ⬇️
parser ∅ <ø> (∅)
br 51.1546% <ø> (+5.2862%) ⬆️

fmt
fmt
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 19, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 20, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 21, 2024
Copy link

ti-chi-bot bot commented Feb 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-20 06:26:56.882852063 +0000 UTC m=+338505.630475170: ☑️ agreed by lance6716.
  • 2024-02-21 02:06:14.714061548 +0000 UTC m=+409263.461684659: ☑️ agreed by Benjamin2037.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Feb 21, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit e34702f into pingcap:master Feb 21, 2024
23 checks passed
@D3Hunter D3Hunter deleted the refactor branch February 21, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants