disttask: refine manager retry #51071
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
|
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51071 +/- ##
=================================================
- Coverage 70.5842% 55.1418% -15.4425%
=================================================
Files 1467 1583 +116
Lines 434825 629323 +194498
=================================================
+ Hits 306918 347020 +40102
- Misses 108672 258210 +149538
- Partials 19235 24093 +4858
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| } | ||
|
|
||
| func (m *Manager) runWithRetry(fn func() error, msg string) error { | ||
| backoffer := backoff.NewExponential(scheduler.RetrySQLInterval, 2, scheduler.RetrySQLMaxInterval) |
There was a problem hiding this comment.
Why do we not put this to RunWithRetry? Then we can use it directly.
There was a problem hiding this comment.
maybe too many params?
| if err1 != nil { | ||
| m.logger.Error("update to subtask failed", zap.Error(err1), zap.Stack("stack")) | ||
| m.logger.Warn(msg, zap.Error(err1)) |
There was a problem hiding this comment.
It seems that the error log is printed in RunWithRetry, so could we remove this log?
There was a problem hiding this comment.
I prefer to add some log to indicate where it happens
|
/retest |
|
@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #49008
Problem Summary:
What changed and how does it work?
Use handle.RunWithRetry
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.