parser, ddl: data type default values support UPPER(SUBSTRING_INDEX(user(),'@',1))

[zimulala]

What problem does this PR solve?

Issue Number: close #50966, close #51200

Problem Summary:

What changed and how does it work?

• Data type default values support UPPER(SUBSTRING_INDEX(user(),'@',1))

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50992 (928ab80) into master (a465300) will decrease coverage by 15.3773%.
Report is 27 commits behind head on master.
The diff coverage is 52.0000%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50992         +/-   ##
=================================================
- Coverage   70.6268%   55.2496%   -15.3773%     
=================================================
  Files          1467       1576        +109     
  Lines        434809     607961     +173152     
=================================================
+ Hits         307092     335896      +28804     
- Misses       108517     249137     +140620     
- Partials      19200      22928       +3728     

Flag	Coverage Δ
integration	37.2583% <4.0000%> (?)
unit	70.7233% <52.0000%> (+0.2914%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0571% <ø> (+0.0301%)	⬆️
parser	∅ <ø> (∅)
br	52.2660% <ø> (+6.3976%)	⬆️

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zimulala]

PTAL @tangenta @CbcWestwolf

[tangenta]

Why not support a wider scope like upper(substring_index(*)) or upper(*)?

[zimulala]

For the time being, only the expressions that need to be supported are supported. In addition, these default expressions are supported by different versions of mysql (5.7, 8.0.13, 8.0.34, etc.).

[zimulala]

/check-issue-triage-complete

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [tangenta]
• pkg/parser/OWNERS [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-20 10:16:15.670372923 +0000 UTC m=+352264.417996034: ☑️ agreed by tangenta.
• 2024-02-21 11:56:38.511734212 +0000 UTC m=+444687.259357323: ☑️ agreed by CbcWestwolf.

[zimulala]

/retest-required

[tiprow]

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.