Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix routine leak & refine logs & refactor failpoint #50912

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Feb 1, 2024

What problem does this PR solve?

Issue Number: ref #49008

Problem Summary:

What changed and how does it work?

  • fix routine leak
  • refactor failpoints
  • refine logs
  • random chose nodes for HA cases
  • remove duplicate HA cases

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 1, 2024
Copy link

tiprow bot commented Feb 1, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -170,43 +168,6 @@ func TestOwnerChangeWhenSchedule(t *testing.T) {
require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/pkg/disttask/framework/scheduler/mockOwnerChange"))
}

func TestTaskExecutorDownBasic(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate with cases in ha_test

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #50912 (5ef463f) into master (134d2bf) will increase coverage by 2.2070%.
Report is 17 commits behind head on master.
The diff coverage is 86.9863%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50912        +/-   ##
================================================
+ Coverage   70.5268%   72.7338%   +2.2070%     
================================================
  Files          1467       1467                
  Lines        433920     437015      +3095     
================================================
+ Hits         306030     317858     +11828     
+ Misses       108657      99103      -9554     
- Partials      19233      20054       +821     
Flag Coverage Δ
integration 48.9166% <68.5714%> (?)
unit 70.2672% <84.9315%> (-0.0714%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.1239% <ø> (+5.3864%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 4, 2024
Copy link

ti-chi-bot bot commented Feb 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2024
Copy link

ti-chi-bot bot commented Feb 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-04 03:56:52.92407667 +0000 UTC m=+69938.490846545: ☑️ agreed by okJiang.
  • 2024-02-04 06:08:20.273334132 +0000 UTC m=+77825.840104006: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot bot merged commit 0fff995 into pingcap:master Feb 4, 2024
22 of 23 checks passed
@D3Hunter D3Hunter deleted the add-rou-leak-check branch February 4, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants